Skip to content

make BuildConfigFromConfigFile less sensitive #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 14, 2017

Conversation

tg123
Copy link
Member

@tg123 tg123 commented Nov 11, 2017

this PR is based on #50 and to fix #24, #25

  1. user is not a necessary property now, it will not be checked if set. no user or user: "" are now acceptable.
  2. current-context can be ignore if masterUrl is set. (see testcase NoCurrentContext)
  3. http host will always skip validate the ca settings no master the value of insecure-skip-tls-verify
  4. will throw a bad host exception is host is not set. (was a uri npe)
  5. other cleanup for codes

@brendandburns brendandburns merged commit abc89a1 into kubernetes-client:master Nov 14, 2017
@tg123 tg123 deleted the sensitive_conf branch November 14, 2017 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kubeconfig handling is overly sensitive
2 participants